News methods New format handling CSV NDJSON #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Oct 12, 2021
214: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #230 - #235 - Add new methods: - `addDocumentsJson(string $documents, ?string $primaryKey = null)` - `addDocumentsNdJson(string $documents, ?string $primaryKey = null)` - `addDocumentsCsv(string $documents, ?string $primaryKey = null)` - Add tests for new methods + files - Remove json header `application/json` for every http methods Co-authored-by: meili-bot <[email protected]> Co-authored-by: Amélie <[email protected]> Co-authored-by: alallema <[email protected]>
This was referenced Oct 19, 2021
norkunas
reviewed
Oct 19, 2021
| @@ -8,7 +8,7 @@ interface Http | |||
| { | |||
| public function get($path, array $query = []); | |||
|
|
|||
| public function post(string $path, $body = null, array $query = []); | |||
| public function post(string $path, $body = null, array $query = [], string $content_type = null); | |||
There was a problem hiding this comment.
Why $content_type and not $contentType if in codebase camelCase is used everywhere? :)
There was a problem hiding this comment.
This branch was merged into bump-meilisearch-v0.23.0 and not main. I requested this change in the PR corresponding to the merge of bump-meilisearch-v0.23.0 to main.
#214 (comment)
So good remark, we changed it! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addDocumentsJson(string $documents, ?string $primaryKey = null)addDocumentsNdJson(string $documents, ?string $primaryKey = null)addDocumentsCsv(string $documents, ?string $primaryKey = null)application/jsonfor every http methods